Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nargo): allow running nargo from any directory in package #1010

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Mar 20, 2023

Related issue(s)

Baby step towards #794

Description

Summary of changes

Currently nargo cannot run except in the root directory of a noir package. This is a little annoying if you're in the src directory of a package but nargo isn't smart enough to compile the program inside it.

When running the nargo CLI we now search all ancestor directories for a Nargo.toml file and then run in the context of that directory.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench force-pushed the search-parents-for-manifest branch from b75ba67 to 64efa2d Compare March 20, 2023 15:46
kevaundray
kevaundray previously approved these changes Mar 20, 2023
@kevaundray kevaundray added this pull request to the merge queue Mar 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 20, 2023
* master:
  feat(nargo): add `InvalidPackageError` and `DependencyResolutionError` error types. (#1007)
@TomAFrench TomAFrench requested a review from kevaundray March 21, 2023 08:44
@kevaundray kevaundray added this pull request to the merge queue Mar 21, 2023
@kevaundray kevaundray merged commit 761fdb5 into master Mar 21, 2023
@kevaundray kevaundray deleted the search-parents-for-manifest branch March 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants